Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod annotations configuration #65

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Pod annotations configuration #65

merged 1 commit into from
Nov 4, 2019

Conversation

sjmiller609
Copy link
Contributor

What this PR does / why we need it:

Allow users to configure annotations on the proxy pods.

Sample use case: configuring resources for an istio-proxy sidecar https://discuss.istio.io/t/override-istio-sidecar-proxy-cpu-mem-limits/3226/2

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Changes are documented in the README.md

@sjmiller609
Copy link
Contributor Author

@rimusz Please let me know any feedback. Thank you

@rimusz
Copy link
Owner

rimusz commented Nov 4, 2019

thanks for the PR 👍

@rimusz rimusz merged commit f614a8e into rimusz:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants