Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gcloud-sqlproxy] support cloudproxysql v2 #139

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

mclavel
Copy link
Contributor

@mclavel mclavel commented Aug 3, 2023

What this PR does / why we need it:

Support to use cloud-sql-proxy v2.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

fixes #132

Special notes for your reviewer:

--

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped, is mandatory for any chart chnages
  • Variables and other changes are documented in the README.md
  • Title of the PR starts with chart name (e.g. [gcloud-sqlproxy])

@mclavel mclavel force-pushed the support-cloudsql-v2 branch from d6876bb to 5a769fd Compare August 3, 2023 21:53
@mclavel mclavel marked this pull request as draft August 3, 2023 21:53
@mclavel mclavel force-pushed the support-cloudsql-v2 branch from 5a769fd to 501ee6c Compare August 4, 2023 00:25
@mclavel mclavel marked this pull request as ready for review August 4, 2023 00:27
@mclavel
Copy link
Contributor Author

mclavel commented Aug 7, 2023

@rimusz , @naseemkullah , please take a look 👀
Thanks in advance

@rimusz rimusz self-requested a review August 7, 2023 15:29
Copy link
Owner

@rimusz rimusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rimusz rimusz merged commit 7c9d9cf into rimusz:master Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcloud-sqlproxy - Helm Chart not compatible with cloud-sql-proxy >=2.0.0
2 participants