Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcloud-sqlproxy - HPA kind #142

Closed
tasnyc opened this issue Oct 10, 2023 · 1 comment · Fixed by #148 or #149
Closed

gcloud-sqlproxy - HPA kind #142

tasnyc opened this issue Oct 10, 2023 · 1 comment · Fixed by #148 or #149

Comments

@tasnyc
Copy link
Contributor

tasnyc commented Oct 10, 2023

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG

If this is a BUG REPORT, please:

Version of Helm and Kubernetes:
helm: 3.13.0
kubernetes: 1.24

Which chart:
gcloud-sqlproxy:0.25.2

What happened:
Template is setting my HPA kind as Deployment even though in my values.yaml file i have useStatefulset: true.

What you expected to happen:
Should set the HPA kind as Statefulset instead of Deployment

*** Possible Fix***:
Probably just need an if else statement depending on what useStatefulset is set to in the values.yaml file.

Thank you

@tasnyc
Copy link
Contributor Author

tasnyc commented Oct 13, 2023

gcloud-sqlproxy/templates/horizontalpodautoscaler.yaml

  {{- if .Values.useStatefulset }}
    kind: Statefulset
  {{- else }}
    kind: Deployment
  {{- end }}

rimusz pushed a commit that referenced this issue Nov 4, 2023
* #142 - HPA kind

* updated chart version to 0.25.5
rimusz pushed a commit that referenced this issue Nov 28, 2023
* [gcloud-sqlproxy] HPA kind depends on useStatefulset value - Fix case sensitive  StatefulSet #142

* updated chart version to 0.25.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants