Support CJK Unified Ideographs Extension G in charset_filter #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change charset_filter to support Support CJK Unified Ideographs Extension G
lotem
requested changes
Jul 27, 2020
| @@ -24,6 +24,7 @@ bool is_extended_cjk(uint32_t ch) | |||
| (ch >= 0x2B740 && ch <= 0x2B81F) || // CJK Unified Ideographs Extension D | |||
| (ch >= 0x2B820 && ch <= 0x2CEAF) || // CJK Unified Ideographs Extension E | |||
| (ch >= 0x2CEB0 && ch <= 0x2EBEF) || // CJK Unified Ideographs Extension F | |||
| (ch >= 0x30000 && ch <= 0x3134A) || // CJK Unified Ideographs Extension G | |||
There was a problem hiding this comment.
Please edit the range to match the standard:
https://en.wikipedia.org/wiki/CJK_Unified_Ideographs_Extension_G
Range | U+30000..U+3134F
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change charset_filter to support CJK Unified Ideographs Extension G