Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove import maps to restore commonjs compatibility #177

Merged
merged 1 commit into from
Jul 29, 2023

Conversation

vitoke
Copy link
Contributor

@vitoke vitoke commented Jul 29, 2023

Fixes #175

Removes usage of import maps from package json and code, as this breaks compatibility with CommonJS

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 99.39% and project coverage change: +0.42% 🎉

Comparison is base (6dfcd6c) 96.53% compared to head (a934339) 96.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   96.53%   96.96%   +0.42%     
==========================================
  Files         323      322       -1     
  Lines       54658    54740      +82     
  Branches     6405     6438      +33     
==========================================
+ Hits        52766    53076     +310     
+ Misses       1880     1652     -228     
  Partials       12       12              
Files Changed Coverage Δ
packages/hashed/src/common/hashed-custom.mts 95.65% <ø> (ø)
packages/proximity/src/main/index.mts 0.00% <0.00%> (ø)
packages/actor/src/immer/slice-immer.mts 100.00% <100.00%> (ø)
packages/actor/src/patch/slice-patch.mts 100.00% <100.00%> (ø)
packages/actor/src/stream/index.mts 100.00% <100.00%> (ø)
...ckages/bimap/src/custom/implementation/builder.mts 97.82% <100.00%> (ø)
...ckages/bimap/src/custom/implementation/context.mts 93.63% <100.00%> (+0.24%) ⬆️
...ages/bimap/src/custom/implementation/immutable.mts 95.14% <100.00%> (ø)
packages/bimap/src/custom/interface.mts 100.00% <100.00%> (ø)
packages/bimap/src/main/interface.mts 100.00% <100.00%> (ø)
... and 151 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitoke vitoke merged commit 2712a2e into main Jul 29, 2023
@vitoke vitoke deleted the feature/improve-cjs-compatibility branch July 29, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript compilation error for CommonJS modules
1 participant