Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas: Gracefully handle error states #6629

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Canvas: Gracefully handle error states #6629

merged 5 commits into from
Feb 11, 2025

Conversation

djbarnwal
Copy link
Member

  • Create an error state component and use it for all canvas components
  • Relax constraints for table component

@djbarnwal djbarnwal self-assigned this Feb 10, 2025
ericpgreen2
ericpgreen2 approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@djbarnwal djbarnwal merged commit 6268add into main Feb 11, 2025
7 checks passed
@djbarnwal djbarnwal deleted the feat/canvas-error-state branch February 11, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpgreen2 ericpgreen2 ericpgreen2 approved these changes

Assignees

@djbarnwal djbarnwal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djbarnwal @ericpgreen2