+++ title = "Notes" +++
\toc
- JuliaDynamics/Agents.jl#358 (
findall(!, Y)not considered readable) - fonsp/Pluto.jl#802 (
Vector) - diegozea/MIToS.jl#58 (
Vector) - JuliaLang/Pkg.jl#2301 (my bad; didn't validate)
Generally, rewrites which can easily be validated seem to be more appreciated. For example, compare rewriting 26 occurrences of
f(a, b; c = c)
to
f(a, b; c)
at JuliaDynamics/Agents.jl#357 with rewriting 2 occurrences of
findall(x -> x == false, matches)
to
findall(!, matches)
at https://github.com/JuliaDynamics/Agents.jl/pull/358/files.
Clearly, the former is much bigger, but easier to validate.
Unless the rewrite is easy to validate, bigger rewrites are less likely to be merged.