Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Array{T,1} with Vector{1} #58

Closed
wants to merge 1 commit into from
Closed

Replace Array{T,1} with Vector{1} #58

wants to merge 1 commit into from

Conversation

rikhuijzer
Copy link

Hi! I'm working on a linter, and saw that this repository has 12 occurrences of using

Array{T,1}

where this could be shortened to

Vector{T}

I know that it doesn't shorten the code too much, but I think that overall it does improve the readability, and that is why I open this PR 😄

Feel free to close this PR immediately if you're not interested in this small refactoring.

By the way, the tests fail locally on

RESTful PDB Interface: Test Failed at /home/rik/git/MIT_orig/test/PDB/PDB.jl:276
  Expression: (getpdbdescription("104D"))["resolution"]

with and without applying this PR

@rikhuijzer
Copy link
Author

Sorry! This is not a good refactor, I think. It is confusing since the stack trace shows Array{T,1} even after using Vector{T}. I've removed this refactor completely from the linter.

@rikhuijzer rikhuijzer closed this Dec 23, 2020
@diegozea
Copy link
Owner

I think the error is related to #59 Thanks for pointing out the error and the interest in the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants