Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Riemann Aws ELB: send 0 metric on empty result #155

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

krakatoa
Copy link
Contributor

Hi, with this PR we fill empty datapoints for ELB metrics with zeroes (they have more value than "?" or "null").
Thanks! 👍

@jamtur01
Copy link
Member

Can you elaborate why they are more useful? Just because they are at least integers?

@krakatoa
Copy link
Contributor Author

According ELB Dimensions and Metrics doc (http://docs.aws.amazon.com/AmazonCloudWatch/latest/DeveloperGuide/elb-metricscollected.html), every metric reports a value whenever it is "a nonzero value" or "there are registered instances". So we can fill those zeroes on our side without affecting any of these metrics.
Where's the benefit ? We will see integers instead of "?" in the dashboard. If we want to make any calculation on Riemann server, we don't need to add time windows with a default. That's all.

@jamtur01
Copy link
Member

Cool! Thanks!

jamtur01 added a commit that referenced this pull request Mar 15, 2016
Riemann Aws ELB: send 0 metric on empty result
@jamtur01 jamtur01 merged commit 60a8774 into riemann:master Mar 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants