Escaping HTML in Contact Users Nicknames #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out that if you enter html into a nickname it doesn't get rendered during the initial contact request, but if requested, the html will render in the contacts column and in the setting menu. Mostly this isn't an issue (the odd style issue when users set their nicks to be <h1>) however - it is possible, in the limited 30 character space to construct an <img> tag which - providing they can create a url short enough is enough to automatically render the image and reveal the users IP address. This very simple fix forces contact nick names to have html escaped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that if you enter html into a nickname it
doesn't get rendered during the initial contact request, but
if accepted, the html will render in the contacts column and
in the setting menu.
Mostly this isn't an issue (the odd style issue when users
set their nicks to be h1) however - it is possible, in the
limited 30 character space to construct an img tag which -
providing they can create a url short enough is enough to
automatically render the image and reveal the users IP
address to the server where the image is located.
This fix forces contact nick names to have html escaped.