Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Configuration is already in use" sometimes appears after unexpected exit #73

Closed
special opened this issue Aug 12, 2014 · 0 comments · Fixed by #79
Closed

"Configuration is already in use" sometimes appears after unexpected exit #73

special opened this issue Aug 12, 2014 · 0 comments · Fixed by #79
Labels
Milestone

Comments

@special
Copy link
Member

special commented Aug 12, 2014

The configuration lock file uses a PID to check whether the application is active (through QLockFile), but that check is fragile. If the program doesn't terminate normally and that PID is reused, it will refuse to start, and this is very confusing.

@special special added this to the 1.0.x milestone Aug 12, 2014
special added a commit to special/ricochet that referenced this issue Aug 16, 2014
QLockFile checks whether a process with the PID in the lock file exists,
and assumes the lock is held if one does. In many cases that can result
in false-positive "locked" errors, especially after unexpected reboots.

It's very bad if we tell users that their configuration is in use when
it isn't. To avoid this, try removing stale lock files automatically. On
most systems, if the lock is truly held, the removal will fail and we
can safely display the error.

It's possible that this could allow users on networked filesystems to
launch multiple instances, but that is less of a bug than the existing
one.

Fixes ricochet-im#73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant