Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML entities like " in chat messages #36

Closed
special opened this issue Apr 14, 2014 · 0 comments
Closed

HTML entities like " in chat messages #36

special opened this issue Apr 14, 2014 · 0 comments
Labels
bug ui
Milestone
1.0.2

Comments

@special
Copy link
Member

special commented Apr 14, 2014

Entity escaping in 1.0.1 is apparently overly careful. Some characters like " show up in chat as ".
@special special added this to the 1.0.x milestone Apr 14, 2014
special added a commit that referenced this issue Apr 14, 2014
@special
Fix visible HTML entities in chat messages (#36)
2ea84bb 
For lines of text that don't contain any link, but do contain a HTML
sensitive characters like ", those characters will still be replaced by
their entity values (e.g. "). TextEdit.AutoText does not consider
those to indicate rich text, so they will be displayed verbatim.

Since we always escape HTML characters, we should always parse the
output as HTML, and entities will be correctly decoded.
@special special modified the milestones: 1.0.2, 1.0.x Apr 17, 2014
@special special closed this as completed Jul 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug ui
Projects
None yet
Milestone
1.0.2
Development

No branches or pull requests
1 participant
@special