Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add omitempty to OnlyFailures and TransactionId filed in NotificationHistoryRequest struct #24

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ricky0603
Copy link
Contributor

In NotificationHistoryRequest, according Apple's document, only startTime and endTime are required, all other field is optional.

Specify the constraints for the App Store Server Notification history entries you’re requesting from Get Notification History. The request requires the startDate and endDate fields; all other fields are optional. Include only the fields in your request that you need to constrain the response.

https://developer.apple.com/documentation/appstoreserverapi/notificationhistoryrequest

Copy link
Owner

@richzw richzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your PR

@richzw richzw merged commit 639e355 into richzw:master Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants