If play is failing I suspect some attributes such as isDynamic to be …

…wrong making wrong assumptions in the functional tests. Query dynamic state directly via player API.
richstimson · Jul 22, 2022 · 97b58a8 · 97b58a8
1 parent 1ff9797
commit 97b58a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/test/functional/tests/pause.js b/test/functional/tests/pause.js
@@ -62,8 +62,9 @@ exports.register = function(stream) {
                 await command.sleep(PAUSE_DELAY * 1000);
 
                 const time = await command.execute(player.getTime);
+                const isDynamic = await command.execute(player.isDynamic);
                 utils.log(NAME, 'Playback time = ' + time);
-                if (stream.dynamic) {
+                if (isDynamic) {
                     // For dynamic streams, when paused, current time is progressing backward
                     assert.isAtMost(time, (pauseTime - PAUSE_DELAY + 1)); // +1 for 1 sec tolerance
                 } else {

diff --git a/test/functional/tests/playFromTime.js b/test/functional/tests/playFromTime.js
@@ -30,7 +30,8 @@ exports.register = function (stream) {
             utils.log(NAME, 'Load stream');
             command = remote.get(intern.config.testPage);
             originalUrl = stream.url;
-            if (!stream.dynamic) {
+            const isDynamic = await command.execute(player.isDynamic);
+            if (!isDynamic) {
                 let period = stream.periods[stream.periods.length - 1];
                 startTime = period.start + Math.min(TIME_OFFSET, period.duration - 5);
                 stream.url += '#t=' + startTime;
@@ -50,7 +51,8 @@ exports.register = function (stream) {
             utils.log(NAME, 'Play');
             const playing = await command.executeAsync(player.isPlaying, [constants.EVENT_TIMEOUT]);
             assert.isTrue(playing);
-            const time = await command.execute(stream.dynamic ? player.getTimeAsUTC : player.getTime);
+            const isDynamic = await command.execute(player.isDynamic);
+            const time = await command.execute(isDynamic ? player.getTimeAsUTC : player.getTime);
             utils.log(NAME, 'Playback time: ' + time);
             assert.isAtLeast(time, startTime);
             assert.isAtMost(time, (startTime + 5));