Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add characters for The Final Voyage of Draengr Thar 1 shot adventure #316

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

pablocampogo
Copy link
Contributor

Add characters for the The Final Voyage of Draengr Thar 1 shot adventure.

These GCS files are the ones directly downloaded from 1shotadventure websute

Copy link
Collaborator

@dripton dripton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like the gcs files straight from the 1shotadventures site. Looks like they were made in 2022. Have you tried them in the latest gcs and do they work okay?

@pablocampogo
Copy link
Contributor Author

These look like the gcs files straight from the 1shotadventures site. Looks like they were made in 2022. Have you tried them in the latest gcs and do they work okay?

Yes they are!, and yes they work on the latest GCS

@dripton
Copy link
Collaborator

dripton commented Aug 30, 2024

Okay, we already have some other 1shotadventures characters in the repo, and JC Connors (who runs that site and writes the adventures) seems committed to sharing this stuff for free, so I think it's fine to add these to the master repository to save GMs who run this adventure the bother of downloading and importing them. I'll go ahead and merge them.

@dripton dripton closed this Aug 30, 2024
@dripton dripton reopened this Aug 30, 2024
Copy link
Collaborator

@dripton dripton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, these look unchanged from the ones on 1shotadventures, and pablocampogo confirms they still work with latest GCS.

@dripton dripton merged commit a3c09e3 into richardwilkes:master Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants