Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes to the Goblin files allow for latest GCS version #272

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

ethorad
Copy link
Collaborator

@ethorad ethorad commented Jan 4, 2024

Equipment file:
Amended all weapons to have +0 parry (except for some of the Glaive ones which retained their +2 parry)

Goblin Emissary:
Removed a "Placeholder" trait I use to make it easier to add new traits to the end in the right group.

Hobgoblin Witch Doctor:
Didn't really make any changes as it all looked OK with no parry or block permitted on the spells. Saving it seems to have removed those rows from the save file so it shows up as a change.

Equipment file:
Amended all weapons to have +0 parry (except for some of the Glaive ones which retained their +2 parry)

Goblin Emissary:
Removed a "Placeholder" trait I use to make it easier to add new traits to the end in the right group.

Hobgoblin Witch Doctor:
Didn't really make any changes as it all looked OK with no parry or block permitted on the spells.  Saving it seems to have removed those rows from the save file so it shows up as a change.
@ethorad ethorad requested a review from rinickolous as a code owner January 4, 2024 15:07
@ethorad
Copy link
Collaborator Author

ethorad commented Jan 4, 2024

Think this might be be largely superfluous given the change I've just accepted from fish. As such the only change is probably removing the place holder trait I left in one of the templates

Copy link
Collaborator

@rinickolous rinickolous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@rinickolous rinickolous merged commit 186f24d into richardwilkes:master Jan 7, 2024
@ethorad ethorad deleted the MoreWeaponStatUpdates branch January 27, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants