fix: always set the YARN_IGNORE_ENGINES env variable (nodejs#738)

Fixes: nodejs#737
richardlau · May 15, 2019 · c3917aa · c3917aa
1 parent 278a6d3
commit c3917aa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 1 deletion.
diff --git a/lib/create-options.js b/lib/create-options.js
@@ -17,6 +17,10 @@ function createOptions(cwd, context) {
   options.env['TEMP'] = context.npmConfigTmp;
   options.env['TMP'] = context.npmConfigTmp;
   options.env['TMPDIR'] = context.npmConfigTmp;
+  // Explicitly tell yarn to ignore the "engines" field in `package.json`.
+  // If dependencies of tested modules have set it and CITGM is testing an
+  // unreleased version of Node.js, this prevents `yarn install` from failing.
+  options.env['YARN_IGNORE_ENGINES'] = 'true';
 
   if (context.options.nodedir) {
     const nodedir = path.resolve(process.cwd(), context.options.nodedir);

diff --git a/lib/lookup.json b/lib/lookup.json
@@ -144,7 +144,6 @@
     "prefix": "v",
     "maintainers": "SimenB",
     "yarn": true,
-    "envVar": { "YARN_IGNORE_ENGINES": true },
     "skip": ["aix"]
   },
   "esprima": {

diff --git a/test/test-create-options.js b/test/test-create-options.js
@@ -32,6 +32,7 @@ test('create-options:', (t) => {
   env['TEMP'] = 'npm_config_tmp';
   env['TMP'] = 'npm_config_tmp';
   env['TMPDIR'] = 'npm_config_tmp';
+  env['YARN_IGNORE_ENGINES'] = 'true';
   // Set dynamically to support Windows.
   env['npm_config_nodedir'] = path.resolve(process.cwd(), nodePath);