Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up PR for #233
#233 seemed to exclude empty files from req.files but for temporary files, it still creates a writestream right after busboy triggers the
.on("file")
method, I did some research in hopes to find a flag forfs.createWriteStream
to actually check and remove if the file is empty on the end but there's no such a thing.And we are not able to not create a stream while we can't get the size info until the end, so the best thing we can do is follow the condition we have on
file.on('end')
and cleanup iftemporaryFiles
is enabled.