-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes semistandard
dependency to be a range
#72
Conversation
Thanks for fixing this @gabmontes. @ricardofbarros can we get this merged please? |
Though you would only get the bugfix when reinstalling the atom package. I don't think that this helps, unless I'd rather use something like http://greenkeeper.io/ and release on every update of semistandard and standard, but that's just my opinion. In the end it's @ricardofbarros decision. |
@despairblue you are right as this will not fix current broken installs but every new install will break as semistandard@7.0.2 is buggy. In this scenarios, the advice is to first fix the issue ASAP and then find a better solution if any. @ricardofbarros this is super quick fix that can be merged immediately. We are 2 weeks since 7.0.3 release and this PR submission. Please comment on this. Thanks! |
👍 Ran into this issue also, what version should I roll back to? |
@ricardofbarros are you still maintaining this repository ? |
@OlivierCuyp his last activity on GitHub was a month ago. I tried to publish a temporary package on Atom with the fix baked in, but there was some kind of conflict, and I am not familiar enough with apm to fix the issue. Can someone try? |
Hey guys. Yes I'm still maintaining this package and there's a upcoming major version. I don't want this to be a range because there have been some issues in the past with patch versions of semistandard, standard, etc.. and that's why I block to a specific version that I'm confident it will work. If I don't block the version it becomes nuisance to debug, for instance someone installs this package and raises an issue that it doesn't work, but I have the latest version and everything is fine, the problem would be the dependencies of this package and that is very painful to coordinate the efforts to debug that specific issue. |
Fair enough! But in the case of this issue, a range would have fixed things without any interventions from your side. In the meantime, could you please push a fix with semistandard 7.0.4? I keep seeing an error when there is actually none, and it's kind of annoying. ;) |
👍 for greenkeeper, what version is good to roll back to for now? |
For others with this issue you can roll back to 2.5.0 with To 'solve' this issue we could use greenkeeper, however we could also add an option to use the user's globally installed binary? |
+1 I ran into this issue as well and it is rather annoying that your linter wrongly tells you something is wrong when it isn't - I am not doing React yet get |
Hello guys, @devtristan PR fixed this issue. Many thanks to him. 🎉 🎉 This fix is already published as 3.3.0. Thanks. |
Version 7.0.2 of
semistandard
has some issues like standard/semistandard#38 and 7.0.3 fixes it. But since the module is required by exact version inpackage.json
, the new version is not pulled from NPM.This PR changes
package.json
to requiresemistandard
as a range to include any bug fixes that may become available.