Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable if eslint config is present #197

Merged
merged 6 commits into from
Aug 12, 2017
Merged

disable if eslint config is present #197

merged 6 commits into from
Aug 12, 2017

Conversation

chee
Copy link
Contributor

@chee chee commented Aug 9, 2017

closes #194

works for me
ready to make any fixes necessary

now i can leave linter-js-standard and linter-eslint enabled and comfortably switch between projects

πŸ’šβ€οΈπŸ’œπŸ’› q^β€Ώ^q πŸ’›πŸ’œβ€οΈπŸ’š

@chee
Copy link
Contributor Author

chee commented Aug 9, 2017

it adds a dependency (find-root), but that dependency was already a dependency of an already included dependency (pkg-config)

@Arcanemagus
Copy link
Contributor

This is a simplified version of what ESLint does, you can find documentation on that here. Over in linter-eslint we implement the entire logic here, but with an exclusion for the "home folder" config when checking the "Disable when no ESLint config" option.

@sonicdoe
Copy link
Collaborator

Thank you for the pull request, @chee. I think it would be great to split out this check into a separate module (for example, uses-eslint). Would you be interested in publishing such a package?

@chee
Copy link
Contributor Author

chee commented Aug 11, 2017

sure, @sonicdoe, i'll do that !

@chee
Copy link
Contributor Author

chee commented Aug 11, 2017

@sonicdoe

https://github.com/chee/detect-eslint-config i did that

https://www.npmjs.com/package/detect-eslint-config

given a file path it recursively checks for eslint config until it hits a package.json, at which point it stops.

it ignores homedir eslint config.

will update this pr to use it once i get get some πŸ₯“ 🍳 .

@chee
Copy link
Contributor Author

chee commented Aug 11, 2017

updated and pushed

@sonicdoe sonicdoe merged commit 7444f86 into ricardofbarros:master Aug 12, 2017
@sonicdoe
Copy link
Collaborator

Thanks πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable when an ESLint configuration file was found
3 participants