This repository has been archived by the owner on Jul 8, 2021. It is now read-only.
Support for ES6 modules #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 16, 2019 11:36
BREAKING CHANGE: As output JavaScript has ES6 module format now, supporting ES5 targets requires additional transpilation.
|
@rhysforyou Is there any chance to merge this? |
|
@rhysforyou do you need help with the maintenance of governance of the project? It would be a pleasure for me to help with that. |
|
@erykpiast more than happy to have others help out. I haven't been able to give much time to this project, and haven't been using Reason in any recent projects, so I'm a little rusty. If there are those in the community who want to help out, I'd greatly appreciate it. |
rhysforyou
approved these changes
Jan 29, 2020
|
@rhysforyou great! I'll try to go through the backlog over the weekend and at least think about unresolved issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It resolves #14 but potentially breaks projects compiled directly to ES5.