e2e: Foreground delete for revisions and services in e2e (knative#794)

* e2e: Foreground delete for revisions and services in e2e to avoid any race conditions and flakes * Use --wait instead of --no-wait=false Signed-off-by: Roland Huß <roland@ro14nd.de> # Conflicts: # test/e2e/basic_workflow_test.go # test/e2e/revision_test.go
rhuss · Apr 15, 2020 · 0ac58ec · 0ac58ec
1 parent d52a5aa
commit 0ac58ec
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/test/e2e/basic_workflow_test.go b/test/e2e/basic_workflow_test.go
@@ -129,7 +129,7 @@ func serviceUpdate(t *testing.T, it *test.KnTest, r *test.KnRunResultCollector,
 }
 
 func serviceDelete(t *testing.T, it *test.KnTest, r *test.KnRunResultCollector, serviceName string) {
-	out := it.Kn().Run("service", "delete", serviceName)
+	out := it.Kn().Run("service", "delete", "--wait", serviceName)
 	r.AssertNoError(out)
 	assert.Check(t, util.ContainsAll(out.Stdout, "Service", serviceName, "successfully deleted in namespace", it.Kn().Namespace()))
 }

diff --git a/test/e2e/revision_test.go b/test/e2e/revision_test.go
@@ -98,7 +98,7 @@ func revisionListWithService(t *testing.T, it *test.KnTest, r *test.KnRunResultC
 }
 
 func revisionDelete(t *testing.T, it *test.KnTest, r *test.KnRunResultCollector, revName string) {
-	out := it.Kn().Run("revision", "delete", revName)
+	out := it.Kn().Run("revision", "delete", "--wait", revName)
 	assert.Check(t, util.ContainsAll(out.Stdout, "Revision", revName, "deleted", "namespace", it.Kn().Namespace()))
 	r.AssertNoError(out)
 }