Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsr305 should be an optional dependency #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

gehel
Copy link

@gehel gehel commented Jun 23, 2017

Fixes #74

@gehel
Copy link
Author

gehel commented Jun 23, 2017

I have no idea how gradle works, I need to do some reading before actually committing something :(

@gehel gehel closed this Jun 23, 2017
@sslavic
Copy link

sslavic commented Aug 4, 2017

Why close PR?

There's compileOnly in Gradle 2.12+ (see here)

Upgraded Gradle to 2.12 (to support compileOnly).
@gehel gehel reopened this Aug 7, 2017
@gehel
Copy link
Author

gehel commented Aug 7, 2017

PR updated as suggested by @sslavic. The travis build is failing, but this does not seem to be related to my PR (the build is also failing locally without the change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants