Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter datasources on Thanos mixin dashboards #454

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

jacobbaungard
Copy link
Member

With this commit we filter the available datasources on the grafana dashboards provided by the bundled thanos mixin dashboards. This should make it significantly easier to find the data needed.

The regex used currently will show the following datasources:

  • app-sre-stage-01-prometheus
  • rhobs-testing-cluster-prometheus
  • rhobs-testing-prometheus
  • rhobsp02ue1-cluster-prometheus
  • rhobsp02ue1-prometheus
  • telemeter-prod-01-prometheus

Any additional datasources starting with rhobs will be added if they become available.

Updates Thanos mixin to the latest version, which has the following PR as diff: thanos-io/thanos#6273

With this commit we filter the available datasources on the grafana
dashboards provided by the bundled thanos mixin dashboards. This should
make it significantly easier to find the data needed.

The regex used currently will show the following datasources:
- app-sre-stage-01-prometheus
- rhobs-testing-cluster-prometheus
- rhobs-testing-prometheus
- rhobsp02ue1-cluster-prometheus
- rhobsp02ue1-prometheus
- telemeter-prod-01-prometheus

Any additional datasources starting with `rhobs` will be added if they
become available.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
@jacobbaungard
Copy link
Member Author

I wasn't able to figure out how to get rid of the cluster-prometheus datasources (which are not interesting for us), while still having a dynamic filter on rhobs. If someone is a regex wizard, feel free to add a suggestion 🙂

Copy link
Contributor

@douglascamata douglascamata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@douglascamata douglascamata merged commit 583babe into main Apr 12, 2023
@douglascamata douglascamata deleted the dashboard-filter branch April 12, 2023 14:00
jacobbaungard added a commit to jacobbaungard/configuration that referenced this pull request Apr 13, 2023
Following on from: rhobs#454 we
now use the same filter for the receive controller dashboard, which
comes from the thanos-receive-controller rather than Thanos itself.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
douglascamata pushed a commit that referenced this pull request Apr 13, 2023
Following on from: #454 we
now use the same filter for the receive controller dashboard, which
comes from the thanos-receive-controller rather than Thanos itself.

Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants