This repository has been archived by the owner on Sep 22, 2020. It is now read-only.
Direct all creation of TypeMeta object to func TypeMeta(kind, apiVersion string) in meta package (GITOPS-81) #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eta function Coauthored by @bigkevmcd <kmcdermo@redhat.com>
meta.TypeMeta which will simplify the task of adapting if we need to support old and new for a period.
meta.TypeMeta which will simplify the task of adapting if we need to support old and new for a period.meta.TypeMeta
meta.TypeMeta * Rename and not to use "createXXX" as var names
wtam2018
approved these changes
Mar 21, 2020
bigkevmcd
pushed a commit
that referenced
this pull request
May 15, 2020
…ion string) in meta package (GITOPS-81) (#45) * made required changes for the TypeMeta value to go via the meta.TypeMeta function Coauthored by @bigkevmcd <kmcdermo@redhat.com> * Un-captialized package local variable pipelineTypeMeta * * Refactor to reuse package local var * Rename and not to use "createXXX" as var names Co-authored-by: William Tam <email.wtam@gmail.com>
wtam2018
added a commit
that referenced
this pull request
May 25, 2020
…ion string) in meta package (GITOPS-81) (#45) * made required changes for the TypeMeta value to go via the meta.TypeMeta function Coauthored by @bigkevmcd <kmcdermo@redhat.com> * Un-captialized package local variable pipelineTypeMeta * * Refactor to reuse package local var * Rename and not to use "createXXX" as var names Co-authored-by: William Tam <email.wtam@gmail.com>
wtam2018
added a commit
that referenced
this pull request
May 26, 2020
…ion string) in meta package (GITOPS-81) (#45) * made required changes for the TypeMeta value to go via the meta.TypeMeta function Coauthored by @bigkevmcd <kmcdermo@redhat.com> * Un-captialized package local variable pipelineTypeMeta * * Refactor to reuse package local var * Rename and not to use "createXXX" as var names Co-authored-by: William Tam <email.wtam@gmail.com>
wtam2018
added a commit
that referenced
this pull request
May 27, 2020
…ion string) in meta package (GITOPS-81) (#45) * made required changes for the TypeMeta value to go via the meta.TypeMeta function Coauthored by @bigkevmcd <kmcdermo@redhat.com> * Un-captialized package local variable pipelineTypeMeta * * Refactor to reuse package local var * Rename and not to use "createXXX" as var names Co-authored-by: William Tam <email.wtam@gmail.com>
wtam2018
added a commit
that referenced
this pull request
Jun 17, 2020
…ion string) in meta package (GITOPS-81) (#45) * made required changes for the TypeMeta value to go via the meta.TypeMeta function Coauthored by @bigkevmcd <kmcdermo@redhat.com> * Un-captialized package local variable pipelineTypeMeta * * Refactor to reuse package local var * Rename and not to use "createXXX" as var names Co-authored-by: William Tam <email.wtam@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change tektoncd/triggers#332 will cause us to rework the API groups for our resources.
In order to simplify supporting the new v1beta1 and types, we should indirect through
meta.TypeMetawhich will simplify the task of adapting if we need to support old and new for a period.Fixes https://issues.redhat.com/browse/GITOPS-81