Allow fallback to default loader when encountering errors on network boot #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70129e1 to
956a394
Compare
8 tasks
dbnicholson
reviewed
Sep 10, 2024
3fe5014 to
99410b2
Compare
Only certain errors trigger fall back to the default loader name. This change allows fall back when encountering `EFI_TFTP_ERROR` and `EFI_HTTP_ERROR`. This fixes the issue reported in rhboot#649 that prevents boot on some models of PC. Signed-off-by: Nathan O'Meara <Nathan.OMeara@tanium.com>
99410b2 to
13bdd63
Compare
vathpela
approved these changes
Jan 21, 2025
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only certain errors trigger fallback to the default loader name. This change allows fallback when encountering
EFI_TFTP_ERRORas well. And ideally would also handleEFI_HTTP_ERRORthe same way, but that requires updating gnu-efi to a version newer than the shim-15.8 branch.This fixes the issue reported in #649 that prevents boot on some models of PC.