pe: simplify generate_hash() #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given that there is no "datasize_out" and that most of the function code uses "datasize" maybe it's better to rename the function argument to "datasize" and then drop all references to "size" and "datasize_in"? this should make the diff smaller, no? |
|
@xnox: Thank you for reviewing. I will update the patch and force push it. |
1a5e1d6 to
ef870d7
Compare
|
@xnox: I have update the patch according to your recommendation. Please, review again. |
ef870d7 to
96a3804
Compare
|
Rebased on current origin/main |
frozencemetery
requested changes
Sep 10, 2021
cd6660d to
3e68352
Compare
Copying the value of datasize_in to two further variables and then using all three randomly in the code makes it hard to read. datasize_in is never changed in generate_hash() so we can do with this parameter alone. Rename it to datasize. Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
3e68352 to
0cc4db3
Compare
|
@frozencemetery: thank you for reviewing. I removed const and force pushed to corrected patch. |
frozencemetery
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copying the value of datasize_in to two further variables and then using
all three randomly in the code makes it hard to read.
datasize_in is never changed in generate_hash() so we can do with this
parameter alone. Let's declare it as const to verify that its value
is invariant.
Signed-off-by: Heinrich Schuchardt heinrich.schuchardt@canonical.com