Minor code updates #243
Merged
Minor code updates #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids NULL dereference. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
The API prescribes use of setmntent(). Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Don't include <byteswap.h> and use __builtin_bswap16() in one place. It's already used in the rest of places, this just completes the transition to the builtin. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
I don't think it's being used. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
<uchar.h> is glibc-specific and it's not even guaranteed to be 2 bytes long! typedef __uint_least16_t char16_t; uint16_t seems much more appropriate here. Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
|
@vathpela Hi, any chance to take a look at this? If merged, this would reduce code differences a bit, which should help with maintenance and broader usage of this tool not only in Linux, but also in BSD systems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While making this project work on BSD systems (in limited capacity) I stumbled upon some things in the code which you might want to fix. Of course, there were more changes related to compatibility, but given that the project is targeting Linux I've skipped them and submitting only those which make sense to apply in general.