src/Makefile: build util.c separately for makeguids #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
floppym
reviewed
Jan 18, 2022
src/Makefile
Outdated
| MAKEGUIDS_OBJECTS = $(patsubst %.S,%.o,$(patsubst %.c,%.o,$(MAKEGUIDS_SOURCES))) | ||
| MAKEGUIDS_OUTPUT = $(GENERATED_SOURCES) guids.lds | ||
|
|
||
| util-makeguids.c : |
There was a problem hiding this comment.
You should change this to depend on util.c, so that the copy happens automatically whenever util.c is modified.
Suggested change
| util-makeguids.c : | |
| util-makeguids.c : util.c |
frozencemetery
approved these changes
Jun 8, 2022
util.c needs to be built twice when cross-compiling: for the build machine to be able to link with makeguids which then runs during the same build, and then for the actual target. Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util.c needs to be built twice when cross-compiling:
for the build machine to be able to link with
makeguids which then runs during the same build,
and then for the actual target.
Signed-off-by: Alexander Kanavin alex@linutronix.de