-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Sbat_Level_Variable.txt from shim repo #12
Open
jsetje
wants to merge
7
commits into
rhboot:main
Choose a base branch
from
jsetje:use_SbatLevel_Variable.txt_from_shim_repo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use Sbat_Level_Variable.txt from shim repo #12
jsetje
wants to merge
7
commits into
rhboot:main
from
jsetje:use_SbatLevel_Variable.txt_from_shim_repo
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This covers delivering updates to SBAT_LEVEL without the need to create and sign a new shim Signed-off-by: Jan Setje-Eilers <Jan.SetjeEilers@oracle.com>
Signed-off-by: Jan Setje-Eilers <Jan.SetjeEilers@oracle.com>
This is also included in shim builtin latest revocation, but it revokes shim binaries impacted by: * CVE-2023-40547 * CVE-2023-40546 * CVE-2023-40548 * CVE-2023-40549 * CVE-2023-40550 * CVE-2023-40551 And also revokes GRUB binaries impacted by: * CVE-2023-4692 * CVE-2023-4693
When the term previous was introduced for revocations to be automatically applied there was a hope that everytime a new revocation was built into shim, the previous revocation could be applied automatically. Further experience has shown the real world to be more complex than that. The automatic payload will realistically contain a set of revocations governed by both the cadence at which a distro's customer base updates as well as the severity of the issue being revoked. This is not a functional change. Signed-off-by: Jan Setje-Eilers <Jan.SetjeEilers@oracle.com>
With shim added as a git module this allows builds to specify revocations from SbatLevel_Variable.txt on the command line they currently default to: SBAT_LATEST_DATE=2023012950 SBAT_AUTOMATIC_DATE=2023012900 Signed-off-by: Jan Setje-Eilers <jan.setjeeilers@oracle.com>
I should probably add a way to build time select SkuSi as automatic or not and also build the separate with the right names. Will add that shortly. (done) |
Automatically build revocations_sbat.efi and revocations_sku.efi binaries that contain only sbat and SkuSi revocation payloads. Signed-off-by: Jan Setje-Eilers <Jan.SetjeEilers@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on a previous PR and extracts the revocation metadata from the shim repo.