Updates to PEP 725 after first round of review #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rowser (python#3521) Add 'make htmllive' to rebuild and reload HTML files in your browser
PySide was listed as a binding generator for Qt, but PySide is the final project. The name of the used binding generator that PySide uses, is Shiboken.
PEP 702 says that the deprecation policy should be updated to encourage use of @deprecated for deprecations.
pradyunsg
approved these changes
Nov 18, 2023
|
And, thank you for splitting this across multiple commits. It made this easier to review! |
msarahan
approved these changes
Nov 20, 2023
Also drop the sentence from the abstract implying the WG members are the PEP authors (the correspondence is now a mere coincidence).
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
The added Pillow example and changes to Cryptography and Scipy code from testing builds in https://github.com/rgommers/external-deps-build.
65a11cc to
3d840a9
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Thank you for the reviews @pradyunsg and @msarahan. I'll move this the main PEPs repo now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses most (but not yet all) actionable comments on https://discuss.python.org/t/pep-725-specifying-external-dependencies-in-pyproject-toml/31888.
Closes gh-10
Closes gh-11
📚 Documentation preview 📚: https://pep-previews--13.org.readthedocs.build/