fix bswap for odd number of bytes
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #38. `bswap` was seeming to work well since Julia v1.6, but LLVM documents that `bswap` is valid only for an even number of bytes (https://llvm.org/docs/LangRef.html#llvm-bswap-intrinsics), and a julia build with LLVM asserts enabled catches that. NB: to enable LLVM asserts, put the following in "Make.user" : ``` FORCE_ASSERTIONS=1 LLVM_ASSERTIONS=1 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38.
bswapwas seeming to work well since Julia v1.6, but LLVM documents thatbswapis valid only for an even number of bytes(https://llvm.org/docs/LangRef.html#llvm-bswap-intrinsics), and a julia build with LLVM asserts enabled catches that.
NB: to enable LLVM asserts, put the following in "Make.user" :