Fix tests on Julia 1.4: narrow element type of vv vector to fix test error on Julia 1.4 #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing packages for the upcoming Julia 1.4 we found that this package tests errored. The reason boils down to the following difference:
In 1.3, the resulting type was a
SparseMatrixCSC{AbstractFloat,Int64}
.This PR fixes the test error by "narrowing" the element type of
vv
(so if it only contains e.g.Float32
s,vv
will become aVector{Float32}
instead of aVector{AbstractFloat}
).Disregarding the change in 1.4, this is likely to be better since it will give a concrete element type to the sparse matrix in most cases which will make future operations with it more efficient.