🌐 Basics of web search #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@asim-shrestha whats the plan for this |
awtkns
approved these changes
May 1, 2023
| @@ -16,4 +16,44 @@ describe("Strings should be extracted from arrays correctly", () => { | |||
| "Integrate with external tools and services to provide users with additional features such as task prioritization and scheduling." | |||
| ); | |||
| }); | |||
|
|
|||
| it("fails with single quotes", () => { | |||
|
|
||
| async executeTask(task: string, analysis: Analysis): Promise<string> { | ||
| // Run search server side since clients won't have a key | ||
| if (this.shouldRunClientSide() && analysis.action !== "search") { |
There was a problem hiding this comment.
Cant wait to remove this client side stuff. It will help to reduce our package size :)
| knowledgeGraph?: KnowledgeGraph; | ||
| organic?: OrganicResult[]; | ||
| relatedSearches?: RelatedSearch[]; | ||
| sportsResults?: SportsResults; |
There was a problem hiding this comment.
this is oddly specific for a web search api 😆
awtkns
reviewed
May 1, 2023
| const options = { | ||
| method: "POST", | ||
| headers: { | ||
| "X-API-KEY": this.key, |
There was a problem hiding this comment.
Regarding this key are we going to get ratelimitted here?
awtkns
reviewed
May 1, 2023
| constructor(modelSettings: ModelSettings, goal: string) { | ||
| super(); | ||
|
|
||
| this.key = process.env.SERP_API_KEY ?? ""; |
There was a problem hiding this comment.
We should put the SERP_API_KEY in the environment schema as an optional.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image when searching:
Image for when SERP_API is not in ENV: (Will still build)
