feat: add combobox for export options #292
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice, we should ensure hover effects trigger on the entire group. Looks like hovering the drop down icon doesn't trigger the glow. Tailwind has a group handler we can use for this. We should also be able to click anywhere on the button. Looks like only the dropdown itself works currently |
This might have to do with the fact that the other combobox is editable so some inconsistency here. TBH we probably don't even want it to be editable |
| @@ -167,6 +168,35 @@ const MacWindowHeader = (props: HeaderProps) => { | |||
| void navigator.clipboard.writeText(text); | |||
| }; | |||
|
|
|||
| const exportOptions = [ | |||
There was a problem hiding this comment.
Should we extract an ExportComboBox element?
|
Hi @asim-shrestha, reimplemented the dropdown with the new menu component.
|
|
Nice work here! Thoughts on keeping the save to db button outside the ddl? In doing that we could then rename it it to export. |
src/components/ChatWindow.tsx
Outdated
| @@ -167,8 +168,34 @@ const MacWindowHeader = (props: HeaderProps) => { | |||
| void navigator.clipboard.writeText(text); | |||
| }; | |||
|
|
|||
| const exportOptions = [ | |||
| <WindowButton | |||
| key="Agent" | |||
There was a problem hiding this comment.
@awtkns, I grouped save agent button under the dropdown menu.
- it will be disabled unless
onSaveis not undefined
I prefer it outside as well since it will be more obvious to the users. It's mostly a responsive thing. not enough space for both when the screen is small. but I just have an idea now. taking a look |
|
We could also do a ping animation in the DDL for when export to DB is available: https://tailwindcss.com/docs/animation#ping |
|
@asim-shrestha @awtkns not what i had in mind an hour ago but i have separated out the Save agent button. It's closer to what we have in production.
|
|
@Jshen123 not sure why merging is blocked... i can force merge it for you if you want |
Description:
Export buttons are now grouped under one dropdown
other