Chore // Bumped up test version #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grossvogel
approved these changes
Aug 8, 2024
grossvogel
reviewed
Aug 8, 2024
| @@ -89,7 +89,7 @@ defmodule SlaxWeb.Poker do | |||
| estimates = | |||
| round.estimates | |||
| |> Enum.sort_by(& &1.value) | |||
| |> Enum.map(&"#{&1.user} (#{&1.value})#{if &1.reason, do: ': #{&1.reason}'}") | |||
| |> Enum.map(&"#{&1.user} (#{&1.value})#{if &1.reason, do: ~c": #{&1.reason}"}") | |||
There was a problem hiding this comment.
Anybody know why we're using charlists here?
There was a problem hiding this comment.
That's really funky
There was a problem hiding this comment.
It also shows up as funky from the syntax highlight in my vscode now; but it does still work
There was a problem hiding this comment.
wait that's just being the " and the : are so close together so it thinks it's supposed to be an atom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I forgot to bump up the test version in #446 - this should sort that out