673 Deploy Conditions, Semantic Release ENV Var Naming #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for romantic-goldberg-d768af ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
quinnmccourt
approved these changes
Apr 19, 2024
grossvogel
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
Changed the Tagged OR Master branch conditions to an AND.
I think it probably doesn't matter in the case of this library, but I just wanted to point out that this OR logic might be intentional rather than an error.
Sometimes there are multiple major or minor versions that are supported in tandem, so you might make a security fix to your latest version on master (tagged and released as 5.0.4 for example) and then back-port that fix to your still-supported 4.1.X branch, where you tag and release it as version 4.1.12.
texastoast
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#676