Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note to self: check continuous fuzzing #74

Closed
darosior opened this issue Mar 19, 2021 · 1 comment · Fixed by #80
Closed

Note to self: check continuous fuzzing #74

darosior opened this issue Mar 19, 2021 · 1 comment · Fixed by #80
Milestone
End of March demo

Comments

@darosior
Copy link
Member

No description provided.

@darosior darosior added this to the End of March demo milestone Mar 19, 2021
@darosior darosior mentioned this issue Apr 4, 2021
Merged
@darosior
Copy link
Member Author

darosior commented Apr 5, 2021

Done.

@darosior darosior closed this as completed Apr 5, 2021
darosior added a commit that referenced this issue Apr 7, 2021
@darosior
Merge #80: Update rust-miniscript, pre-demo cleanups
7ff8de4 
546ee51 Cargo: bump version to '0.2.0' (Antoine Poinsot)
0076df1 Cargo: never activate rust-bitcoin's "use-serde" feature (Antoine Poinsot)
20bc6d6 ci: fuzz against our generated corpus (Antoine Poinsot)
322ac7f transactions: derive Spend transaction from outpoints and amounts (Antoine Poinsot)
90f305d transactions: build transaction chain from deposit outpoint and txo (Antoine Poinsot)
b8cd7c5 transactions: add txid getters (Antoine Poinsot)
6a10e81 scripts: add a CSV getter to the Unvault descriptor (Antoine Poinsot)
60a0c8b fuzz: use secp256k1's global context (Antoine Poinsot)
80bfdcc transactions: make sure the Spend transaction size is standard (Antoine Poinsot)
d025a86 scripts: require minimal CSV (Antoine Poinsot)
b5478f4 scripts: use rust-miniscript's constants for sequence bit flags (Antoine Poinsot)
baebf79 transactions: fixup CSV tests after Miniscript update (Antoine Poinsot)
bee2254 Tree-wide: misc doc cleanups (Antoine Poinsot)
ca77be2 scripts: implement to/from str for descriptors newtypes (Antoine Poinsot)
b0be252 scripts: add constructors for derived descriptors type (Antoine Poinsot)
3aa53ba scripts: encapsulation for the descriptors (Antoine Poinsot)
b7ab05a Cargo: use a smaller alternative to rust-secp's rand (Antoine Poinsot)
cb29b3a Tree-wide: update rust-miniscript to the latest major version (Antoine Poinsot)

Pull request description:

  This updates rust-miniscript after an overhaul of the type system for descriptor. We leverage it to refactor our descriptor types on our end too, resulting in a much cleaner API.

  This also contains a bunch of fixes that were waiting on a rust-miniscript update or were needed for the demo.

  Fixes #64
  Fixes #74
  Fixes #41
  Fixes #59

ACKs for top commit:
  danielabrozzoni:
    utACK 546ee51 -- Reviewed briefly, looks good to me :)
  edouardparis:
    utACK 546ee51
  darosior:
    ACK 546ee51

Tree-SHA512: f0dfe8fa6925c33788b3b04ebd34bba16288f667767909ea7e270497717bbe663298775e77545a6f3937df20e984a8ac5e22f49cf8af3058105e9d7b3c28c3b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
End of March demo
Development

Successfully merging a pull request may close this issue.

Update rust-miniscript, pre-demo cleanups darosior/revault_tx
1 participant
@darosior