Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A LoggerAdapter interface for integration with other logging packages #66

Closed
wants to merge 1 commit into from

Conversation

morawskim
Copy link

This PR closes #21

See discussion from this task to get more details.

WARNING This PR break backward compatibility

@reugn
Copy link
Owner

reugn commented Sep 11, 2023

@morawskim, thanks for looking into the issue.
I understand the requirement for a logger adapter in the library and created a more comprehensive implementation of it without introducing breaking changes, see #67.
Please review and let me know what you think.

@morawskim
Copy link
Author

@reugn For me awesome 😍
Very nice solution to prevent introducing breaking changes.

@reugn reugn closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable logging "The Job '*' got out the execution loop"?
2 participants