Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a trivia game #19

Merged
merged 24 commits into from
Jul 30, 2021
Merged

Add a trivia game #19

merged 24 commits into from
Jul 30, 2021

Conversation

0xVR
Copy link
Collaborator

@0xVR 0xVR commented Oct 1, 2020

This adds a fun trivia game to the bot, with customizable settings and many different topics.

@retrixe retrixe self-requested a review October 5, 2020 14:27
retrixe
retrixe requested changes Apr 21, 2021
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are my initial looks at the code.
The command needs to be added to the README and /help.
Also these triviaLists look really big, including them in the repository, hmm will think about it.

server/bot/imports/types.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/imports/tools.ts Outdated Show resolved Hide resolved
@retrixe retrixe self-requested a review July 5, 2021 19:24
retrixe
retrixe requested changes Jul 18, 2021
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR almost looks good, I need to look more closely at the trivia, since that's the most complex part, but this is what I can see right now.

server/index.ts Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
0xVR and others added 2 commits July 24, 2021 13:54
@0xVR @retrixe
Apply suggestions from code review
dfcb8fc 
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
@0xVR
Fix bugs with /trivia and remove redundant code
2675409
retrixe
retrixe requested changes Jul 26, 2021
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the trivia and found a whole bunch of issues, hopefully it's in good shape afterwards, but there might be other problems and redundancy I might find, hopefully not many more reviews will be required after this one.

server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
@0xVR @retrixe
Apply suggestions from code review
074f83e 
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
retrixe requested changes Jul 28, 2021
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found more potential errors and bugs and stuff that could be cleaned up, and left patches for the constructor changes I suggested.

server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
0xVR and others added 2 commits July 29, 2021 12:35
@0xVR
Use fs.promises and move constants
d9eb41b
@0xVR @retrixe
Apply suggestions from code review
902caea 
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
retrixe requested changes Jul 29, 2021
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the PR is in pretty good shape now, just need to resolve existing reviews, test and merge.

server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
retrixe
retrixe requested changes Jul 29, 2021
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed broken await.

server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/index.ts Outdated Show resolved Hide resolved
0xVR and others added 2 commits July 30, 2021 12:10
@0xVR
Remove redundant code and fix bugs following code review
af379b8
@0xVR @retrixe
Apply suggestions from code review
7d044d7 
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
retrixe reviewed Jul 30, 2021
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add medals like so when the game ends.

server/bot/imports/tools.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
server/bot/commands/trivia.ts Outdated Show resolved Hide resolved
0xVR and others added 3 commits July 30, 2021 17:14
retrixe
retrixe approved these changes Jul 30, 2021
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, everything seems to be well done now!

  • We could use fuse.js for answer matching so typos and mistakes would be alright.
  • The way trivia lists are distributed is not ideal.
  • The flag soup for the command is kinda gross.

But all in all it's good enough to merge now.

@retrixe retrixe merged commit 7cca342 into retrixe:master Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrixe retrixe retrixe approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xVR @retrixe