Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /suppress #18

Merged
merged 6 commits into from
Nov 6, 2020
Merged

Add /suppress #18

merged 6 commits into from
Nov 6, 2020

Conversation

0xVR
Copy link
Collaborator

@0xVR 0xVR commented Oct 1, 2020

This allows anyone with Manage Messages to suppress (or unsuppress!) the embeds on a message.

Note: The code is slightly messy due to missing typings. Also, it makes use of the request handler to avoid being hit with a DiscordRESTError [50005]

@retrixe retrixe self-requested a review October 5, 2020 13:49
retrixe
retrixe requested changes Oct 5, 2020
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only are there are a lot of stuff that can be fixed, but there is no shortage of duplicate code, I'm only stopping here since the code is littered with too many comments from me. Apply these in batch and check back for more.

server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
retrixe
retrixe requested changes Oct 5, 2020
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove even more redundant code that could be common.

server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
retrixe
retrixe requested changes Oct 5, 2020
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we're done here with code cleanup, it looks good to me after these changes now.

server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
server/bot/commands/utilities.ts Outdated Show resolved Hide resolved
0xVR and others added 6 commits November 6, 2020 22:50
@0xVR @retrixe
Add suppress
c094007
@0xVR @retrixe
Apply suggestions from code review
e45d63e 
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
@0xVR @retrixe
Apply suggestions from code review
b1e7b7b 
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
@0xVR @retrixe
Apply suggestions from code review
9d09780 
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
@0xVR @retrixe
Fix syntax error and add command to /help
e866bed
@retrixe
Update fullDesc, fix bug and remove casts.
a1b6101 
These casts are no longer needed with Eris 0.14.0.
retrixe
retrixe approved these changes Nov 6, 2020
View reviewed changes
Copy link
Owner

@retrixe retrixe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still a bit unsightly, but okay.

@retrixe retrixe changed the title Add embed suppression to the bot Add /suppress Nov 6, 2020
@retrixe retrixe merged commit 4803615 into retrixe:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrixe retrixe retrixe approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xVR @retrixe