-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove isomorphic-fetch and imports/exports loaders (fixes #590, #571, #477, #420) #593
Conversation
…, replace webpack specific syntax in fetch.js and move it to webpack config
The tests are failing for some reason. It looks like the module not found error, but you explicitly remove that require, so I'm not sure what's causing it |
Did you reinstall the dependencies?
|
@deontologician sorry my fault. will fix. |
This reverts commit 90bc2d0.
Things to keep in mind now: I changed it to just use the whatwg-fetch. It's just a polyfill for browsers. What that means is just that, if you use the horizon client somewhere else than web - people have to make sure that fetch is either available natively or via a manually added polyfill. I've been able to successfully use the client in node too. I had to put WebSocket onto the global object though before requiring/importing @horizon/client. |
👏 |
I sure hope this resolves most of the problems with fetch. I didnt have a chance to give it a spin with react native though, would be great if someone could try |
@flipace I would be glad to test, how would I do that? Just pull this and build? |
@benjick I'm not sure tbh. I know that React Native has some issues when you try to npm link packages, so you might have to pull the next branch and copy it directly into your projects node_modules folder. |
Any ETA on when a version with this will be released? It's a blocker for my projects… |
@passcod This will go into Horizon 2.0.0. We were hoping to release a release candidate of 2.0.0 this week, but I think it's going to be early next week. |
FYI - Horizon 2.0 beta has been released: https://discuss.horizon.io/t/horizon-v2-0-0-beta/433 2016-08-05 17:28 GMT-07:00 Daniel Mewes notifications@github.com:
|
Great, thank you! |
replace webpack specific syntax in fetch.js and move it to webpack config
This change is