Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove isomorphic-fetch and imports/exports loaders (fixes #590, #571, #477, #420) #593

Merged
merged 3 commits into from
Jun 15, 2016

Conversation

flipace
Copy link
Contributor

@flipace flipace commented Jun 15, 2016

replace webpack specific syntax in fetch.js and move it to webpack config


This change is Reviewable

flipace added 2 commits June 15, 2016 12:52
…, replace webpack specific syntax in fetch.js and move it to webpack config
@flipace flipace changed the title remove isomorphic-fetch and imports/exports loaders (#590, #571, #477, #420) remove isomorphic-fetch and imports/exports loaders (fixes #590, #571, #477, #420) Jun 15, 2016
@deontologician
Copy link
Contributor

The tests are failing for some reason. It looks like the module not found error, but you explicitly remove that require, so I'm not sure what's causing it

@flipace
Copy link
Contributor Author

flipace commented Jun 15, 2016

Did you reinstall the dependencies?
Am 15.06.2016 7:11 Nachm. schrieb "Josh Kuhn" notifications@github.com:

The tests are failing for some reason. It looks like the module not found
error, but you explicitly remove that require, so I'm not sure what's
causing it


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#593 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AA6OgAFaMqkv8dNXDOWc-S80B3IY-IA4ks5qMDJcgaJpZM4I2PRt
.

@flipace
Copy link
Contributor Author

flipace commented Jun 15, 2016

@deontologician sorry my fault. will fix.

@flipace
Copy link
Contributor Author

flipace commented Jun 15, 2016

Things to keep in mind now:

I changed it to just use the whatwg-fetch. It's just a polyfill for browsers.
All the "universal" fetch packages had flaws in combination with the build chain which i have not been able to work around.

What that means is just that, if you use the horizon client somewhere else than web - people have to make sure that fetch is either available natively or via a manually added polyfill.

I've been able to successfully use the client in node too. I had to put WebSocket onto the global object though before requiring/importing @horizon/client.

@deontologician
Copy link
Contributor

👏

@deontologician deontologician merged commit 0688a3e into rethinkdb:next Jun 15, 2016
@deontologician
Copy link
Contributor

deontologician commented Jun 15, 2016

:lgtm: merging

deontologician pushed a commit that referenced this pull request Jun 16, 2016
…#477, #420) (#593)

* remove isomorphic-fetch and imports/exports loaders, use whatwg-fetch, replace webpack specific syntax in fetch.js and move it to webpack config

* remove deprecated loaders

* Revert "remove deprecated loaders"

This reverts commit 90bc2d0.
@flipace
Copy link
Contributor Author

flipace commented Jun 16, 2016

I sure hope this resolves most of the problems with fetch. I didnt have a chance to give it a spin with react native though, would be great if someone could try

@benjick
Copy link

benjick commented Jun 16, 2016

@flipace I would be glad to test, how would I do that? Just pull this and build?

@flipace
Copy link
Contributor Author

flipace commented Jun 16, 2016

@benjick I'm not sure tbh. I know that React Native has some issues when you try to npm link packages, so you might have to pull the next branch and copy it directly into your projects node_modules folder.

@BBB BBB mentioned this pull request Aug 3, 2016
@passcod
Copy link

passcod commented Aug 5, 2016

Any ETA on when a version with this will be released? It's a blocker for my projects…

@danielmewes
Copy link
Member

@passcod This will go into Horizon 2.0.0. We were hoping to release a release candidate of 2.0.0 this week, but I think it's going to be early next week.

@danielmewes danielmewes modified the milestones: Release 2.0, Release 1.x.x Aug 6, 2016
@dalanmiller
Copy link
Contributor

FYI - Horizon 2.0 beta has been released:

https://discuss.horizon.io/t/horizon-v2-0-0-beta/433

2016-08-05 17:28 GMT-07:00 Daniel Mewes notifications@github.com:

@passcod https://github.com/passcod This will go into Horizon 2.0.0. We
were hoping to release a release candidate of 2.0.0 this week, but I think
it's going to be early next week.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#593 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA0sNpTOoKnXkysTBo4v7lHKsngMRumpks5qc9VGgaJpZM4I2PRt
.

@passcod
Copy link

passcod commented Aug 10, 2016

Great, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants