Implement ANY (OR) evaluation mode #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Represents better what the field does
Because it is the exact same logic as in rules with their conditions we change the field `type` to `eval_mode`
71a3290 to
918abc9
Compare
ivanAlfonsoVillaVazquez
approved these changes
Sep 20, 2024
erickgnavar
reviewed
Sep 20, 2024
This is a new feature not a patch
CevaMenelao
approved these changes
Sep 20, 2024
BaltaRT25
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Until now rules can only be evaluated as a whole as ANDs (where all conditions have to be true). Now with the
eval_modeyou can choose for rules to be evaluated where only one of the conditions needs to be true.