Introduce release_archive for packaging the Kotlin rules.

Added //:rules_kotlin_release to build a release.

Issue: bazelbuild#269 (comment)

BUILD

@@ -11,6 +11,8 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+load("//kotlin/internal/utils:packager.bzl", "release_archive")
+load("//kotlin/internal/utils:utils.bzl", "utils")
 
 exports_files([
     "scripts/noop.sh",
@@ -33,3 +35,23 @@ test_suite(
         "//src/test/kotlin/io/bazel/kotlin:local_assertion_tests",
     ],
 )
+
+# Release target.
+release_archive(
+    name = "rules_kotlin_release",
+    srcs = [
+        ":build",
+        ":workspace",
+    ],
+    dist_files = {
+        "BUILD": "",
+        "WORKSPACE": """workspace(name = "io_bazel_rules_kotlin")""",
+    },
+    extension = "tgz",
+    visibility = ["//visibility:public"],
+    deps = [
+        "//kotlin:pkg",
+        "//src/main/kotlin:pkg",
+        "//third_party:pkg",
+    ],
+)

WORKSPACE

@@ -80,6 +80,11 @@ rbe_autoconfig(
     name = "buildkite_config",
 )
 
+load(
+    "//third_party/jvm:workspace.bzl", "maven_dependencies",
+)
+
+maven_dependencies()
 load("//kotlin:kotlin.bzl", "kotlin_repositories", "kt_register_toolchains")
 
 kotlin_repositories()
@@ -126,3 +131,8 @@ maven_install(
     ],
 )
 
+http_archive(
+    name = "rules_pkg",
+    url = "https://github.com/bazelbuild/rules_pkg/releases/download/0.2.4/rules_pkg-0.2.4.tar.gz",
+    sha256 = "4ba8f4ab0ff85f2484287ab06c0d871dcb31cc54d439457d28fd4ae14b18450a",
+)

examples/dagger/BUILD

@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 load("@rules_java//java:defs.bzl", "java_binary", "java_library", "java_plugin")
+
 package(default_visibility = ["//visibility:private"])
 
 load("//kotlin:kotlin.bzl", "kt_jvm_library")

examples/node/BUILD

@@ -15,22 +15,22 @@ load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_js_import")
 
 # Create kt_js_imports for KotlinX's Coroutines and Atomicfu libraries.
 #
-# These could be imported using package.json and NPM, but they are here as an example of how to 
+# These could be imported using package.json and NPM, but they are here as an example of how to
 # use KotlinJS libraries hosted on Maven directly.
 #
 # Note: It's important that the `name`s correspond to the base name of the library only (ie. not-ending with -js/_js)
 kt_js_import(
     name = "kotlinx-coroutines-core",
     jars = [
-        "@maven//:org_jetbrains_kotlinx_kotlinx_coroutines_core_js"
+        "@maven//:org_jetbrains_kotlinx_kotlinx_coroutines_core_js",
     ],
     visibility = ["//:__subpackages__"],
 )
 
 kt_js_import(
     name = "kotlinx-atomicfu",
     jars = [
-        "@maven//:org_jetbrains_kotlinx_atomicfu_js"
+        "@maven//:org_jetbrains_kotlinx_atomicfu_js",
     ],
     visibility = ["//:__subpackages__"],
 )

examples/node/coroutines-helloworld/BUILD

@@ -17,16 +17,16 @@ load("@build_bazel_rules_nodejs//:defs.bzl", "nodejs_binary")
 kt_js_library(
     name = "app",
     srcs = ["Main.kt"],
+    visibility = ["//visibility:public"],
     deps = [
         "//:kotlinx-coroutines-core",
     ],
-    visibility = ["//visibility:public"],
 )
 
 nodejs_binary(
     name = "coroutines-helloworld",
-    node_modules = "@node_ws//:node_modules",
     data = [":app"],
     entry_point = ":app.js",
+    node_modules = "@node_ws//:node_modules",
     visibility = ["//visibility:public"],
 )

examples/node/express/BUILD

@@ -20,25 +20,25 @@ kt_js_library(
     name = "acme-routes",
     srcs = [":Routes.kt"],
     deps = [
-        "//express/auth:acme-auth", 
         "//:kotlinx-atomicfu",
         "//:kotlinx-coroutines-core",
+        "//express/auth:acme-auth",
     ],
 )
 
 kt_js_library(
-    name ="app",
+    name = "app",
     srcs = [":App.kt"],
     deps = [
-        ":acme-routes", 
+        ":acme-routes",
         "//:kotlinx-coroutines-core",
     ],
 )
 
 # The binary demonstrates an express app composed of three modules. The modules can co-exist in the same directory.
 nodejs_binary(
     name = "express",
-    node_modules = "@node_ws//:node_modules",
     data = [":app"],
     entry_point = ":app.js",
+    node_modules = "@node_ws//:node_modules",
 )

examples/node/express/auth/BUILD

@@ -16,5 +16,5 @@ load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_js_library")
 kt_js_library(
     name = "acme-auth",
     srcs = ["Auth.kt"],
-    visibility=["//visibility:public"]
+    visibility = ["//visibility:public"],
 )

kotlin/BUILD

@@ -11,3 +11,13 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+load("//kotlin/internal/utils:packager.bzl", "release_archive")
+
+release_archive(
+    name = "pkg",
+    srcs = glob(["*.*"]) + ["BUILD"],
+    visibility = ["//visibility:public"],
+    deps = [
+        "//kotlin/internal:pkg",
+    ],
+)

kotlin/internal/BUILD

@@ -15,4 +15,4 @@
 load("//kotlin/internal:toolchains.bzl", "kt_configure_toolchains")
 
 # Configures the toolchains
-kt_configure_toolchains()
+kt_configure_toolchains()

kotlin/internal/js/BUILD

@@ -11,9 +11,28 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+load("//kotlin/internal/utils:packager.bzl", "release_archive")
 
+# TODO(https://github.com/bazelbuild/rules_kotlin/issues/270): Replace with Starlark
 py_binary(
     name = "importer",
     srcs = ["importer.py"],
     visibility = ["//visibility:public"],
 )
+
+release_archive(
+    name = "pkg",
+    srcs = glob([
+        "*.bzl",
+        "*.py",
+    ]),
+    dist_files = {
+        "BUILD": """
+py_binary(
+  name = "importer",
+  srcs = ["importer.py"],
+  visibility = ["//visibility:public"],
+)""",
+    },
+    visibility = ["//visibility:public"],
+)

kotlin/internal/js/impl.bzl

@@ -111,6 +111,7 @@ def _strip_version(jarfile):
     if not jarfile.endswith(".jar"):
         fail("_strip_version expects paths ending with .jar")
     segments = jarfile[:-len(".jar")].split("-")
+
     # Remove the last segment if all digits separated by dot
     parts = segments[-1].split(".")
     if len([p for p in parts if not p.isdigit()]) == 0:

kotlin/internal/jvm/android.bzl

@@ -36,7 +36,7 @@ def _kt_android_artifact(name, srcs = [], deps = [], plugins = [], **kwargs):
         srcs = srcs,
         deps = base_deps + [base_name],
         plugins = plugins,
-        testonly = kwargs.get("testonly", default=0),
+        testonly = kwargs.get("testonly", default = 0),
         visibility = ["//visibility:private"],
     )
     return [base_name, kt_name]
@@ -49,6 +49,6 @@ def kt_android_library(name, exports = [], visibility = None, **kwargs):
         name = name,
         exports = exports + _kt_android_artifact(name, **kwargs),
         visibility = visibility,
-        tags = kwargs.get("tags", default=None),
-        testonly = kwargs.get("testonly", default=0),
+        tags = kwargs.get("tags", default = None),
+        testonly = kwargs.get("testonly", default = 0),
     )

kotlin/internal/jvm/compile.bzl

@@ -232,7 +232,7 @@ def kt_jvm_compile_action(ctx, rule_kind, output_jar):
         progress_message = progress_message,
         input_manifests = input_manifests,
         env = {
-            "LC_CTYPE": "en_US.UTF-8" # For Java source files
+            "LC_CTYPE": "en_US.UTF-8",  # For Java source files
         },
     )
 

kotlin/internal/repositories/BUILD

@@ -11,3 +11,10 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+load("//kotlin/internal/utils:packager.bzl", "release_archive")
+
+release_archive(
+    name = "pkg",
+    srcs = glob(["*.*"]) + ["BUILD"],
+    visibility = ["//visibility:public"],
+)

kotlin/internal/repositories/BUILD.com_github_jetbrains_kotlin

@@ -22,7 +22,6 @@ filegroup(
     srcs = glob(["**"]),
 )
 
-
 kt_jvm_import(
     name = "annotations",
     jar = "lib/annotations-13.0.jar",

kotlin/internal/repositories/repositories.bzl

@@ -23,10 +23,6 @@ load(
     "//kotlin/internal:defs.bzl",
     _KT_COMPILER_REPO = "KT_COMPILER_REPO",
 )
-load(
-    "//third_party/jvm:workspace.bzl",
-    _maven_dependencies = "maven_dependencies",
-)
 
 _BAZEL_JAVA_LAUNCHER_VERSION = "0.28.1"
 
@@ -62,7 +58,6 @@ def kotlin_repositories(compiler_release = _KOTLIN_CURRENT_COMPILER_RELEASE):
     Args:
         compiler_release: (internal) dict containing "urls" and "sha256" for the Kotlin compiler.
     """
-    _maven_dependencies()
     _http_archive(
         name = _KT_COMPILER_REPO,
         urls = compiler_release["urls"],

kotlin/internal/toolchains.bzl

@@ -117,7 +117,7 @@ _kt_toolchain = rule(
         "jvm_runtime": attr.label_list(
             doc = "The implicit jvm runtime libraries. This is internal.",
             default = [
-                Label("@" + _KT_COMPILER_REPO + "//:kotlin-stdlib")
+                Label("@" + _KT_COMPILER_REPO + "//:kotlin-stdlib"),
             ],
             providers = [JavaInfo],
             cfg = "target",

kotlin/internal/utils/BUILD

@@ -11,3 +11,10 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+load("//kotlin/internal/utils:packager.bzl", "release_archive")
+
+release_archive(
+    name = "pkg",
+    srcs = glob(["*.bzl"]) + ["BUILD"],
+    visibility = ["//visibility:public"],
+)

kotlin/internal/utils/packager.bzl

@@ -0,0 +1,110 @@
+load("@rules_pkg//:pkg.bzl", "pkg_tar")
+
+def release_archive(name, dist_files = {}, srcs = None, renames = {}, **kwargs):
+    """
+    Creates a tar files for rules_kotlin distribution.
+
+    Args:
+        name: target identifier, points to a pkg_tar target.
+        dist_files: dict of <filename string>:<contents string> for files to be generated in the distribution artifact.
+        renames: dict of <label>:<name string> for labels to be renamed and included in the distribution.
+        srcs: files to include in the distribution.
+        ext: Extension of the archive. Controls the type of tar file generated.
+    """
+
+    if "package_dir" not in kwargs:
+        pkg_name = native.package_name()
+        local_pkg_index = pkg_name.rfind("/")
+        if local_pkg_index > -1:
+            pkg_name = pkg_name[local_pkg_index:]
+        kwargs["package_dir"] = pkg_name
+
+    # Convenience visibility.
+    kwargs["visibility"] = ["//visibility:public"]
+    if srcs == None:
+        srcs = []
+    for path, content in dist_files.items():
+        gen_name = name + "_" + path
+        _gen_file(
+            name = gen_name,
+            contents = content,
+            path = path,
+        )
+        srcs += [gen_name]
+
+    for source, target in renames.items():
+        rename_name = name + "_" + target
+        _rename(
+            name = rename_name,
+            source = source,
+            target = target,
+        )
+        srcs += [rename_name]
+
+    pkg_tar(
+        name = name,
+        srcs = srcs,
+        **kwargs
+    )
+
+_file_header = """
+# Copyright 2020 The Bazel Authors. All rights reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+"""
+
+def _gen_file_impl(ctx):
+    """
+    Creates a file in a directory based on the rule name.
+    Useful for creating source files that may overlap existing sources in a given directory.
+
+    ** This is not windows safe. **
+
+    Args:
+        path: a valid, raltive path string. Unvalidated.
+        contents: string to write to the path.
+    """
+    out = ctx.actions.declare_file(ctx.label.name + "/" + ctx.attr.path)
+    ctx.actions.write(out, _file_header + ctx.attr.contents)
+    return [DefaultInfo(files = depset([out]))]
+
+_gen_file = rule(
+    implementation = _gen_file_impl,
+    attrs = {
+        "contents": attr.string(mandatory = True),
+        "path": attr.string(mandatory = True),
+    },
+)
+
+def _rename_impl(ctx):
+    out_file = ctx.actions.declare_file(ctx.label.name + "/" + ctx.attr.target)
+    in_file = ctx.file.source
+    ctx.actions.run_shell(
+        inputs = [in_file],
+        outputs = [out_file],
+        progress_message = "%s -> %s" % (in_file, ctx.attr.target),
+        command = "mkdir -p {dir} && cp {in_file} {out_file}".format(
+            dir = ctx.label.name,
+            in_file = in_file.path,
+            out_file = out_file.path,
+        ),
+    )
+    return [DefaultInfo(files = depset([out_file]))]
+
+_rename = rule(
+    implementation = _rename_impl,
+    attrs = {
+        "source": attr.label(allow_single_file = True, mandatory = True),
+        "target": attr.string(mandatory = True),
+    },
+)