Add Eager state support #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 25, 2023
tillrohrmann
reviewed
Jun 5, 2023
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The changes look good to me. Only the MessageHeader::fromMessage looks a bit dangerous right now. Maybe we need to change this method slightly or enrich the StartMessage with more information.
sdk-core-impl/src/main/java/dev/restate/sdk/core/impl/MessageHeader.java
Outdated
Show resolved
Hide resolved
sdk-core-impl/src/main/java/dev/restate/sdk/core/impl/MessageHeader.java
Outdated
Show resolved
Hide resolved
slinkydeveloper
commented
Jun 5, 2023
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void cancel() {} | ||
|
|
||
| static MessageHeader headerFromMessage(MessageLite msg) { |
There was a problem hiding this comment.
Here I copy-pasted the method, rather than using what's in ProtoUtils, to avoid adding the dependency on the test jar (as this package is supposed to be published).
tillrohrmann
requested changes
Jun 5, 2023
2bb068b to
4b3b38e
Compare
slinkydeveloper
added a commit
that referenced
this pull request
Jun 5, 2023
* Support MessageHeader.PARTIAL_STATE_FLAG * Propagate the MessageHeader to the state machine * Implement LocalStateStorage and wire it up * Add the EagerStateTest * Modified the `MessageHeader#fromMessage` to be safer.
4b3b38e to
53bc0d0
Compare
* Support MessageHeader.PARTIAL_STATE_FLAG * Propagate the MessageHeader to the state machine * Implement LocalStateStorage and wire it up * Add the EagerStateTest * Modified the `MessageHeader#fromMessage` to be safer.
53bc0d0 to
58d06b4
Compare
slinkydeveloper
added a commit
that referenced
this pull request
Apr 16, 2024
….a4a8596e a4a8596e Now side effect is part of the protocol (#87) 494f765c Format fec17c9e Change x-restate-user-agent to x-restate-server, to be similar to https://www.rfc-editor.org/rfc/rfc9110#field.server git-subtree-dir: sdk-core/src/main/service-protocol git-subtree-split: a4a8596eab8c554dce0f8f0f1020d5ddc623a305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #86