Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor doc fix #346

Merged
merged 1 commit into from
Jun 6, 2024
Merged

minor doc fix #346

merged 1 commit into from
Jun 6, 2024

Conversation

AhmedSoliman
Copy link
Contributor

Typo + added a note to register the service with CLI

@AhmedSoliman AhmedSoliman marked this pull request as ready for review June 5, 2024 07:59
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Test Results

 50 files  ±0   50 suites  ±0   6m 39s ⏱️ -15s
758 tests  - 1  751 ✅  - 1  7 💤 ±0  0 ❌ ±0 
759 runs  ±0  752 ✅ ±0  7 💤 ±0  0 ❌ ±0 

Results for commit bddb6d2. ± Comparison against base commit de2f240.

This pull request removes 7 and adds 6 tests. Note that renamed tests count towards both.
dev.restate.sdk.TestSerdesTest ‑ Byte: 126
dev.restate.sdk.TestSerdesTest ‑ Double: 0.7386553490205815
dev.restate.sdk.TestSerdesTest ‑ Float: 0.48645276
dev.restate.sdk.TestSerdesTest ‑ Integer: 562222331
dev.restate.sdk.TestSerdesTest ‑ Long: 356782261325852552
dev.restate.sdk.TestSerdesTest ‑ Short: 28262
dev.restate.sdk.serde.jackson.JacksonSerdesTest ‑ [Till, Francesco]
dev.restate.sdk.TestSerdesTest ‑ Byte: 78
dev.restate.sdk.TestSerdesTest ‑ Double: 0.41804452727254193
dev.restate.sdk.TestSerdesTest ‑ Float: 0.19167376
dev.restate.sdk.TestSerdesTest ‑ Integer: -1586787368
dev.restate.sdk.TestSerdesTest ‑ Long: 7141125038743746104
dev.restate.sdk.TestSerdesTest ‑ Short: -13892

@AhmedSoliman AhmedSoliman requested a review from gvdongen June 6, 2024 08:17
@AhmedSoliman AhmedSoliman merged commit c864677 into restatedev:main Jun 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants