Serialize state as JSON. #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
added a commit
to restatedev/e2e
that referenced
this pull request
Jan 30, 2024
|
E2E PR: restatedev/e2e#257 |
igalshilman
approved these changes
Jan 30, 2024
|
Why that? Do you prefer methods over static fields? |
Reads better to me, and also it opens the door for some logic in the future, for example log a deprecation or any other logic that you'd wish. |
|
@slinkydeveloper I can totally live with the static fields as-well |
slinkydeveloper
added a commit
to restatedev/e2e
that referenced
this pull request
Jan 30, 2024
slinkydeveloper
added a commit
to restatedev/e2e
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #206