Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable metadata-api by default #2588

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pcholakov
Copy link
Contributor

Trivial change: enables the HTTP metadata access API by default; this will enable us to run the Jepsen metadata workload against regular Docker builds from main or PR branches.

I double checked that the OpenAPI schema definition is unchanged with the inclusion of this.

@pcholakov pcholakov requested a review from muhamadazmy January 30, 2025 14:52
Copy link

github-actions bot commented Jan 30, 2025

Test Results

  7 files  ±0    7 suites  ±0   4m 53s ⏱️ - 2m 13s
 47 tests ±0   46 ✅ +2  1 💤 ±0  0 ❌ ±0 
182 runs  ±0  179 ✅ +2  3 💤 ±0  0 ❌ ±0 

Results for commit e9ea89a. ± Comparison against base commit b3435b9.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When merging could you update the release.md guidelines to say that release should be built w/o the metadata-api? Maybe that's actually also something that you could add to the release workflow.

@pcholakov
Copy link
Contributor Author

I now see a better way to do this! I think we should only enable the feature in non-release builds - and perhaps even in non-release Docker image builds at that. Let me revise!

@pcholakov pcholakov marked this pull request as draft January 31, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants