Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test ingress attach/getOutput with idempotency key #362

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Test ingress attach/getOutput with idempotency key #362

merged 2 commits into from
Jul 22, 2024

Conversation

slinkydeveloper
Copy link
Collaborator

@slinkydeveloper slinkydeveloper commented Jul 18, 2024 •
edited
Loading

@slinkydeveloper
Copy link
Collaborator Author

slinkydeveloper commented Jul 18, 2024 •
edited
Loading

It is currently not passing because of restatedev/restate#1723, I tested it with this fix and it works

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Test Results

102 files  ±0  102 suites  ±0   22m 49s ⏱️ -19s
 84 tests ±0   84 ✅ ±0  0 💤 ±0  0 ❌ ±0 
217 runs  +2  217 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit c761d9a. ± Comparison against base commit c69673b.

♻️ This comment has been updated with latest results.

tillrohrmann
tillrohrmann approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have this aspect now covered by an e2e test. LGTM. +1 for merging once the runtime bug is fixed.

tests/src/test/kotlin/dev/restate/e2e/runtime/IngressTest.kt Outdated Show resolved Hide resolved
@slinkydeveloper slinkydeveloper merged commit 7fd827c into main Jul 22, 2024
2 checks passed
@slinkydeveloper slinkydeveloper deleted the test-ingress-idempotency branch July 22, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slinkydeveloper @tillrohrmann