Proper musl support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Jan 8, 2024
|
@jackkleeman are you able to use this dev-tools image locally to build cross compiled binaries? I've tried it and it gets stuck in some compilation step. Might be my local env. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to get a full toolchain - musl-devel only gets us gcc, we need g++ etc. Fortunately there are widely used docker containers for arm and x86 that have cross toolchains. We copy those toolchains out into our image, and set all the env vars exactly as we do for gnu targets. Also need to use a linker script to instruct musl targets to always statically link libc++